Dockerfile: reorder instructions for caching#132
Draft
thaJeztah wants to merge 1 commit into
Draft
Conversation
Move things that change less to the start to allow them being cached Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
commented
Feb 2, 2022
Comment on lines
+5
to
+6
| ENTRYPOINT ["/entrypoint.sh"] | ||
| CMD ["/etc/docker/registry/config.yml"] |
Member
Author
There was a problem hiding this comment.
Only "downside" is that technically, if a build fails here, it's non-functional (as the entrypoint etc are not yet copied)
Member
Author
|
TBH; not sure how much this brings in practice as the image would only be rebuilt;
It would be beneficial if a new release happens, but alpine did not change (e.g. if there would be |
Contributor
|
Yeah not sure it gives that much as improvement imo. I also think it can be confusing with other dockerfiles that have this info at the end but not really against it. |
Member
|
Alright, probably not worth it 🤔 Feel free to close @thaJeztah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move things that change less to the start to allow them being cached